Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nginx module more headers #310

Merged
merged 10 commits into from
Jan 5, 2025
Merged

fix: nginx module more headers #310

merged 10 commits into from
Jan 5, 2025

Conversation

fzipi
Copy link
Member

@fzipi fzipi commented Dec 12, 2024

what

  • compile header_more modules

why

  • fix cors

@fzipi fzipi requested a review from theseion December 12, 2024 17:10
@fzipi fzipi force-pushed the fix/nginx-module-more-headers branch 2 times, most recently from 56d5f73 to 04c3b3f Compare December 13, 2024 16:34
theseion
theseion requested changes Dec 25, 2024
View reviewed changes
nginx/Dockerfile Outdated Show resolved Hide resolved
.github/workflows/verifyimage.yml Outdated Show resolved Hide resolved
fzipi added 5 commits December 29, 2024 16:47
@fzipi
chore: build more_headers module
dcaf2b9 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi
fix: insert cors back
058488e 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi
fix: use dynamic module instead
96e82f3 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi
fix: update more_set_headers syntax
7ceca3d 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi
fix: add headers to http + tests
0fd52be 
Signed-off-by: Felipe Zipitria <[email protected]>
@fzipi fzipi force-pushed the fix/nginx-module-more-headers branch from 0772855 to 1f307ab Compare December 29, 2024 19:47
@fzipi fzipi force-pushed the fix/nginx-module-more-headers branch from 1f307ab to a7d160a Compare December 29, 2024 19:48
@fzipi fzipi requested a review from theseion December 29, 2024 19:49
theseion
theseion requested changes Dec 30, 2024
View reviewed changes
.github/workflows/verifyimage.yml Outdated Show resolved Hide resolved
nginx/Dockerfile Outdated Show resolved Hide resolved
nginx/Dockerfile Show resolved Hide resolved
nginx/Dockerfile Outdated Show resolved Hide resolved
nginx/Dockerfile-alpine Show resolved Hide resolved
nginx/Dockerfile-alpine Outdated Show resolved Hide resolved
nginx/Dockerfile Outdated Show resolved Hide resolved
nginx/Dockerfile-alpine Outdated Show resolved Hide resolved
nginx/Dockerfile-alpine Outdated Show resolved Hide resolved
theseion
theseion requested changes Dec 30, 2024
View reviewed changes
nginx/Dockerfile-alpine Outdated Show resolved Hide resolved
theseion
theseion requested changes Dec 30, 2024
View reviewed changes
nginx/Dockerfile Show resolved Hide resolved
nginx/Dockerfile-alpine Show resolved Hide resolved
fzipi
fzipi commented Jan 2, 2025
View reviewed changes
nginx/Dockerfile Outdated Show resolved Hide resolved
nginx/Dockerfile-alpine Outdated Show resolved Hide resolved
@fzipi fzipi force-pushed the fix/nginx-module-more-headers branch from b43ba29 to fbf5a0b Compare January 5, 2025 02:15
@fzipi fzipi requested a review from theseion January 5, 2025 03:39
theseion
theseion approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@theseion theseion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally :D

@theseion theseion merged commit 9d7ede8 into coreruleset:main Jan 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theseion theseion theseion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fzipi @theseion